v1.13.0 — mandatory MCP pre-forward audit + challenge approvals (BREAKING)#17
Merged
Merged
Conversation
…REAKING)
Removes the opt-in/unsafe MCP paths from v1.12.0:
- GateAndForward throws unless constructed with auditStore + auditKeyProvider —
no real MCP side effect without a signed, persisted record (still fail-closed).
- Supplying approvals without an approvalService throws — no raw-node-id path;
an MCP approval is always a server-issued challenge bound to {call,tenant,exp}.
- Pure Gate decisions (no forward, no approvals) still work without the deps.
Callers updated: McpDemo + E2E smoke wire the audit store/key/challenge service
and approve via a minted challenge. Test helper Proxy() and inline forwarding/
approval tests updated; new test asserts the throw-on-misuse contract.
246 passing + 3 env-gated skipped.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the v1.12.0 MCP protections mandatory — there is no longer an unsafe path. 246 passing + 3 env-gated skipped.
Breaking
McpProxy.GateAndForwardthrows unless constructed withauditStore+auditKeyProvider— a real MCP side effect can never occur without a signed, persisted record (still fail-closed if the write fails).approvalServicethrows — no raw-node-id path. An MCP approval is always a server-issued challenge bound to{call fingerprint, tenant, expiry}(MintApprovalChallenge).Gatedecision (no forwarding, no approvals) still works without the deps.Migration
Construct
McpProxywithauditStore,auditKeyProvider,approvalService,tenantId; replace any raw"n1"approval withMintApprovalChallenge(call, …).IntentMesh.McpDemoand theIntentMesh.E2Esmoke are updated as worked examples.Tests
New
Forwarding_requires_an_audit_sink_and_approvals_require_a_challenge_serviceasserts both throws + that a pure Gate still works. Test helper + inline forwarding/approval tests updated to wire the deps and approve via minted challenges.🤖 Generated with Claude Code